feat: allow custom websocket server #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can. See vite.config.js here https://repl.it/@templates/Reactjs |
|
@amasad it works in default mode, but in middleware mode Vite starts a new server for websocket. |
|
Unrelated but this pr may also solves #2372? 🤣 |
yyx990803
reviewed
Mar 15, 2021
| @@ -20,6 +21,7 @@ export interface HmrOptions { | |||
| path?: string | |||
| timeout?: number | |||
| overlay?: boolean | |||
| server?: Server | |||
There was a problem hiding this comment.
Maybe this should be http.Server instead (which is then passed to createWebScoketServer as the first argument)? It feels weird to require the user to create a ws server.
6 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In middleware mode Vite starts a separate websoket server but some cloud IDEs (like repl.it) only expose port 80/443 so a separate server is not an option, this PR adds
config.server.hmr.serverto allow a custom user-provided websocket server.